[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:143
+      if (m_apple_types_up->FindByName(context[1].name,
+                                       [&](DIERef ref) { return false; }))
         return;
----------------
jankratochvil wrote:
> I have found a bug/regression here, during the last check-in there was:
> ```
>        if (!m_apple_types_up->FindByName(context[1].name,
> ```
> Just I cannot test it now myself without OSX.
Just tried that change on macOS, and this indeed fixes the regression. Just waiting for the test suite run to finish to make sure it didn't break something else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77327/new/

https://reviews.llvm.org/D77327