[Lldb-commits] [PATCH] D77602: [lldb/Reproducers] Support new replay mode: passive replay
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 15 09:50:42 PDT 2020
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:305
+ return const_cast<T &>(t);
// We need to make a copy as the original object might go out of scope.
> What's up with the `const_cast` ? Should this maybe take a `T &t` argument and let `T` be deduced as `const U` when needed?
I need to decode the template instantiation error for the details, but we need to return a non-const T.
CHANGES SINCE LAST ACTION
More information about the lldb-commits