[Lldb-commits] [PATCH] D78077: Fix bug in UnwindAssemblyInstEmulation with fp-using codegen and mid-function epilogues

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 14 14:05:21 PDT 2020


jasonmolenda added a comment.

In D78077#1980116 <https://reviews.llvm.org/D78077#1980116>, @clayborg wrote:

> If you test worked, then there is something wrong with this test? See inline comment for copy and paste error


Thanks for catching that.  The test definitely fails without the patch, and works with.  lldb is using that sp_reg_info to re-set the m_fp_is_cfa ivar, which my test clearly does not exercise if it is wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78077/new/

https://reviews.llvm.org/D78077





More information about the lldb-commits mailing list