[Lldb-commits] [lldb] 664fda7 - Fix setting Python3_ROOT_DIR on Windows

Isuru Fernando via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 14 10:51:09 PDT 2020


Author: Isuru Fernando
Date: 2020-04-14T12:50:54-05:00
New Revision: 664fda72eaa3d950ce28f893f5d3ded0c7e7b716

URL: https://github.com/llvm/llvm-project/commit/664fda72eaa3d950ce28f893f5d3ded0c7e7b716
DIFF: https://github.com/llvm/llvm-project/commit/664fda72eaa3d950ce28f893f5d3ded0c7e7b716.diff

LOG: Fix setting Python3_ROOT_DIR on Windows

Summary:
Previously the value of Python3_ROOT_DIR was set to the string
"PYTHON_HOME" instead of the value of the variable named
PYTHON_HOME. This commit fixes that as CMake expects
a path as the value of Python3_ROOT_DIR

Reviewers: #lldb, JDevlieghere, teemperor

Reviewed By: #lldb, JDevlieghere, teemperor

Subscribers: teemperor, JDevlieghere, mgorny, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D77842

Added: 
    

Modified: 
    lldb/cmake/modules/FindPythonInterpAndLibs.cmake

Removed: 
    


################################################################################
diff  --git a/lldb/cmake/modules/FindPythonInterpAndLibs.cmake b/lldb/cmake/modules/FindPythonInterpAndLibs.cmake
index 8f3fa9e70bf5..daf51ba54ad2 100644
--- a/lldb/cmake/modules/FindPythonInterpAndLibs.cmake
+++ b/lldb/cmake/modules/FindPythonInterpAndLibs.cmake
@@ -11,7 +11,7 @@ else()
   if (SWIG_FOUND)
     if ("${CMAKE_SYSTEM_NAME}" STREQUAL "Windows")
       # Use PYTHON_HOME as a hint to find Python 3.
-      set(Python3_ROOT_DIR PYTHON_HOME)
+      set(Python3_ROOT_DIR "${PYTHON_HOME}")
       find_package(Python3 COMPONENTS Interpreter Development)
       if (Python3_FOUND AND Python3_Interpreter_FOUND)
         set(PYTHON_LIBRARIES ${Python3_LIBRARIES})


        


More information about the lldb-commits mailing list