[Lldb-commits] [PATCH] D77327: 1/2: [nfc] [lldb] Introduce DWARF callbacks
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 14 10:11:03 PDT 2020
jankratochvil added a comment.
In D77327#1980079 <https://reviews.llvm.org/D77327#1980079>, @labath wrote:
> The normal semantics of callbacks like these is to return `true` when one wants to continue iterating
OK, fixed, thanks for catching it.
> One cannot guarantee that the `debug_names` section will cover all compilation units in a given file. So we still need to call the manual index to index the rest. However we pass it a list of units it should avoid (see `DebugNamesDWARFIndex` constructor), so we don't index everything twice.
OK, that `llvm::DenseSet<dw_offset_t> units_to_avoid`. Thanks for the explanation, it makes sense now.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits