[Lldb-commits] [PATCH] D78094: [lldb/test] Fix TestLoadUnload

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 14 03:41:09 PDT 2020


mib created this revision.
mib added a reviewer: labath.
mib added a project: LLDB.
Herald added a subscriber: lldb-commits.

[lldb/test] Fix TestLoadUnload failure introduced in e0dbd025131c4d77d8a5050a91d391d950529a8c <https://reviews.llvm.org/rGe0dbd025131c4d77d8a5050a91d391d950529a8c>

It seems that `env_cmd_string` is declared and used few lines under this
self.runCmd expression. I guess this is some left-over from an older
version.

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78094

Files:
  lldb/test/API/functionalities/load_unload/TestLoadUnload.py


Index: lldb/test/API/functionalities/load_unload/TestLoadUnload.py
===================================================================
--- lldb/test/API/functionalities/load_unload/TestLoadUnload.py
+++ lldb/test/API/functionalities/load_unload/TestLoadUnload.py
@@ -186,8 +186,6 @@
                     substrs=[os.path.basename(old_dylib)],
                     matching=True)
 
-        self.runCmd(env_cmd_string)
-
         lldbutil.run_break_set_by_file_and_line(
             self, "d.cpp", self.line_d_function, num_expected_locations=1)
         # After run, make sure the non-hidden library is picked up.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78094.257262.patch
Type: text/x-patch
Size: 615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200414/249bbcbd/attachment.bin>


More information about the lldb-commits mailing list