[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

Sylvestre Ledru via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 10 02:08:07 PDT 2020


sylvestre.ledru added inline comments.


================
Comment at: lldb/source/Utility/XcodeSDK.cpp:72
+  llvm::VersionTuple version = ParseSDKVersion(input);
+  return {sdk, version};
+}
----------------
With older version of the libcstdc++ (some Ubuntu LTS), it fails with:

```
 error: chosen constructor is explicit in copy-initialization
  return {sdk, version};
         ^~~~~~~~~~~~~~
/usr/lib/gcc/i686-linux-gnu/5.3.1/../../../../include/c++/5.3.1/tuple:612:19: note: explicit constructor declared here
        constexpr tuple(_U1&& __a1, _U2&& __a2)
```

@aprantl  Could you please have a look ? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76471/new/

https://reviews.llvm.org/D76471





More information about the lldb-commits mailing list