[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

Thu Apr 9 05:55:49 PDT 2020

jankratochvil added a comment.

In D77327#1971435 <https://reviews.llvm.org/D77327#1971435>, @labath wrote:

> The `bool` return value on all of these methods, is that here just to implement the `fallback` mechanism in DebugNamesDWARFIndex?

Most of them yes. There are still some functions needing to return `bool` to benefit from the early returns from callbacks. I hope I found the minimal set of such `bool` functions (none of those are in `DWARFIndex`).

> Could it be avoided if debug_names index calls the "fallback" *after* it has done its own processing?

Yes. Done so now. I still do not understand what is `DebugNamesDWARFIndex` good for when it always calls `ManualDWARFIndex` anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77327/new/

https://reviews.llvm.org/D77327