[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

[Jaroslav Sevcik via Phabricator via lldb-commits]

jarin added inline comments.


================
Comment at: lldb/source/Target/Memory.cpp:63
     if (pos != m_L1_cache.begin()) {
-      --pos;
+      pos--;
     }
----------------
labath wrote:
> I guess this is a leftover from splitting the patches?
> 
> Speaking of post-increment the [[ http://llvm.org/docs/CodingStandards.html#prefer-preincrement | llvm rule ]] is to use pre-increment whereever possible. I see the test uses post-increment exclusively for no good reason.
But, but,... I only increment/decrement in statement position!

Just kidding, I am sorry, fixed now...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77790/new/

https://reviews.llvm.org/D77790