[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 8 23:58:01 PDT 2020


labath added inline comments.


================
Comment at: lldb/unittests/API/CMakeLists.txt:2
+add_lldb_unittest(APITests
+  TestSBCommandInterpreterTest.cpp
+
----------------
Well.. this is now definitely going to get tested well. :P

While we do have some inconsistency where some test files put "Test" as a prefix and others as a suffix, we definitely don't need to have both in the same file. The Test suffix is a prevailing convention (792 vs. 62), so I recommend sticking to that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77444/new/

https://reviews.llvm.org/D77444





More information about the lldb-commits mailing list