[Lldb-commits] [lldb] 8e40987 - Fix e796c77b26acab0b530ac6516f1dda21b8494733

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 8 10:48:42 PDT 2020


Author: Walter Erquinigo
Date: 2020-04-08T10:48:01-07:00
New Revision: 8e40987e1897276308728d28484fbe93f0a7a1e0

URL: https://github.com/llvm/llvm-project/commit/8e40987e1897276308728d28484fbe93f0a7a1e0
DIFF: https://github.com/llvm/llvm-project/commit/8e40987e1897276308728d28484fbe93f0a7a1e0.diff

LOG: Fix e796c77b26acab0b530ac6516f1dda21b8494733

Failure:
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/14556/testReport/junit/lldb-api/tools_lldb-vscode_breakpoint-events/TestVSCode_breakpointEvents_py/

Diff:
[lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request
https://reviews.llvm.org/D76968

It failed a test TestVSCode_breakpointEvents that only runs Darwin that needed to be updated to match the current logic.
The change is simple.

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py b/lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py
index 3a221cd0478c..aae9cc8cb101 100644
--- a/lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py
+++ b/lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py
@@ -114,5 +114,5 @@ def test_breakpoint_events(self):
                 "breakpoint event is for breakpoint %i" % (foo_bp_id))
         self.assertTrue('line' in breakpoint and breakpoint['line'] > 0,
                 "breakpoint event is has a line number")
-        self.assertTrue("foo.cpp" in breakpoint['source']['path'],
-                "breakpoint event path contains foo.cpp")
+        self.assertNotIn("source", breakpoint,
+                "breakpoint event should not return a source object")


        


More information about the lldb-commits mailing list