[Lldb-commits] [lldb] f30ebf4 - [ManualDWARFIndex] Remove dead code, in preparation for moving this function.

Davide Italiano via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 7 16:28:23 PDT 2020


Author: Davide Italiano
Date: 2020-04-07T16:28:13-07:00
New Revision: f30ebf437851d3c68fd0eee82afbc0cef7373c00

URL: https://github.com/llvm/llvm-project/commit/f30ebf437851d3c68fd0eee82afbc0cef7373c00
DIFF: https://github.com/llvm/llvm-project/commit/f30ebf437851d3c68fd0eee82afbc0cef7373c00.diff

LOG: [ManualDWARFIndex] Remove dead code, in preparation for moving this function.

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp b/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
index cb783314d320..3951a2a32a1b 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
@@ -185,12 +185,6 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
             is_declaration = form_value.Unsigned() != 0;
           break;
 
-        //                case DW_AT_artificial:
-        //                    if (attributes.ExtractFormValueAtIndex(i,
-        //                    form_value))
-        //                        is_artificial = form_value.Unsigned() != 0;
-        //                    break;
-
         case DW_AT_MIPS_linkage_name:
         case DW_AT_linkage_name:
           if (attributes.ExtractFormValueAtIndex(i, form_value))
@@ -223,20 +217,6 @@ void ManualDWARFIndex::IndexUnitImpl(DWARFUnit &unit,
                 // location describes a hard coded address, but we don't want
                 // the performance penalty of that right now.
                 is_global_or_static_variable = false;
-                // if (attributes.ExtractFormValueAtIndex(dwarf, i,
-                //                                        form_value)) {
-                //   // If we have valid block data, then we have location
-                //   // expression bytesthat are fixed (not a location list).
-                //   const uint8_t *block_data = form_value.BlockData();
-                //   if (block_data) {
-                //     uint32_t block_length = form_value.Unsigned();
-                //     if (block_length == 1 +
-                //     attributes.UnitAtIndex(i)->GetAddressByteSize()) {
-                //       if (block_data[0] == DW_OP_addr)
-                //         add_die = true;
-                //     }
-                //   }
-                // }
                 parent_die = nullptr; // Terminate the while loop.
                 break;
 


        


More information about the lldb-commits mailing list