[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 7 14:43:34 PDT 2020
jankratochvil marked 2 inline comments as done.
jankratochvil added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2951
+ type_sp = resolved_type->shared_from_this();
+ break;
}
----------------
aprantl wrote:
> I think I'd prefer a return over a break, (iff they are equivalent!).
Wrote above - This `break` cannot be changed to `return` as in D77327 it will become a callback lambda.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2949
+ type_sp = resolved_type->shared_from_this();
+ break;
}
----------------
This `break` cannot be changed to `return` as in D77327 it will become a callback lambda.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77326/new/
https://reviews.llvm.org/D77326
More information about the lldb-commits
mailing list