[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

[Pavel Labath via Phabricator via lldb-commits]

labath added a reviewer: JDevlieghere.
labath added a subscriber: JDevlieghere.
labath added a comment.

Adding @JDevlieghere as he is in the same time zone and knows about all this stuff. This is on the right track, but changing lldb-dotest is not enough -- you'll also need to change `test/API/lit.cfg.py` as that's what's used for regular "check-lldb" runs. Also, instead of environment variables, please add a command line switch to dotest. Environment variables make it hard to reproduce steps when copy-pasting commands.



================
Comment at: lldb/utils/lldb-dotest/lldb-dotest.in:32
+
+    if lldb_build_intel_pt not in ["", "false", "off", "n", "no", "ignore"] \
+        and not lldb_build_intel_pt.endswith("-NOTFOUND"):
----------------
The usual solution to this is to run `llvm_canonicalize_cmake_booleans` in cmake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77452/new/

https://reviews.llvm.org/D77452