[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil marked 6 inline comments as done.
jankratochvil added inline comments.


================
Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:102
 
+  // Helper iterator for the 'equal_range' method.
+  class CString_iterator {
----------------
aprantl wrote:
> ///
I am sorry but all comments in this file are // . I can make a conversion of the file to Doxygen in a separate file if you wish but I am not sure how much is Doxygen widespread in LLDB etc.


================
Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:103
+  // Helper iterator for the 'equal_range' method.
+  class CString_iterator {
+  public:
----------------
shafik wrote:
> `CStringIterator`? 
This custom iterator has been now dropped upon advice by @labath the standard iterator is enough.


================
Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:134
+  private:
+    const UniqueCStringMap &m_map;
+    const Entry *m_entry_ptr;
----------------
shafik wrote:
> It feels like this should be a pointer, `m_entry_ptr` is a pointer already and most uses in the class use the pointer value already.
This custom iterator has been now dropped upon advice by @labath the standard iterator is enough.
BTW I have seen [[ https://github.com/llvm/llvm-project/commit/6a2eb3671018993c316451884c530d6c208f0b80 | patches ]] all pointers which cannot be `nullptr` to be converted to references which is why I used the reference here. But it is gone now anyway.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77327/new/

https://reviews.llvm.org/D77327