[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:861
+    def is_reproducer():
+        if ('LLDB_REPRODUCER_CAPTURE_PATH' in os.environ or 'LLDB_REPRODUCER_REPLAY_PATH' in os.environ):
+            return "reproducers unsupported"
----------------
Should this use variables from configuration.py now?


================
Comment at: lldb/test/API/lit.cfg.py:68
+if lldb_repro_mode:
+  lit_config.note("Running Shell test with lldb-repo in {} mode.".format(lldb_repro_mode))
+  if lldb_repro_mode == 'capture':
----------------
lldb-repro


================
Comment at: lldb/test/API/lldbtest.py:89
 
+        reproducer_path = os.path.join(tempfile.gettempdir(), testFile)
+        if 'lldb-repro-capture' in test.config.available_features:
----------------
I remember some objections to shoving everything in $TMP. Are we not able to put this in the build dir somewhere?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77588/new/

https://reviews.llvm.org/D77588