[Lldb-commits] [PATCH] D77661: [lldb/Python] Add lldbconfig Python module to make the lldb module configurable.
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 7 11:59:27 PDT 2020
labath added a comment.
Thanks. This looks fine, just a question about the placement of the lldbconfig module.
Comment at: lldb/CMakeLists.txt:130
If we're not going to ship this file, should we place it under `packages/Python/...` (I'm sure there is some place we could put it where it would already be in `sys.path` ? That way it would not be accessible from regular lldb runs, only for those from dotest, which would decrease the likelyhood of lldb suddenly stopping to work after being installed.
Comment at: lldb/bindings/python.swig:131
+INITIALIZE = True
Maybe `_initialize` (the convention for "private" variables in python)?
CHANGES SINCE LAST ACTION
More information about the lldb-commits