[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 7 08:39:47 PDT 2020


labath added a comment.

In D77582#1966962 <https://reviews.llvm.org/D77582#1966962>, @teemperor wrote:

> I think the part of the patch that adds documentation to the existing method should go in (In general all patches that just add documentation have my blanket approval, so please just commit those).


About that... the existing practice has been to attach documentation to the python versions of these interfaces (`bindings/interface/*.i`). Now we started to add it to the c++ headers too. More documentation is always better, but OTOH repetition creates maintenance problems and increases the risk of it going stale. Should choose one of the two interfaces and put all documentation there (and maybe have a way to auto-generate the other one) ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77582/new/

https://reviews.llvm.org/D77582





More information about the lldb-commits mailing list