[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 7 07:34:44 PDT 2020
labath added a reviewer: jingham.
labath added a comment.
I don't have a hard objection to this, but if we're don't have a use for it, I don't see a need for adding it right now.
Particularly as it sounds weird to me that "user commands" are not a subset of "commands". I know that is how the underlying api works, but the underlying api looks weird to me too. However, that one (unlike the SB version) can be changed whenever we want.
As for the test, the same remarks I made on the other review apply here too.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits