[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

Tue Apr 7 07:02:14 PDT 2020

labath added a comment.

Thank you for trying out gtest. I'm very happy that this is working out for you. The test looks fine -- just please move it to `unittests/API` (new folder)  -- that's where it logically belongs as it's testing the API code (and it also avoids dangerous ODR violations resulting from linking in both liblldb and its constituent libraries).

It sounds like you and Jim have mostly agreed on the way this should be implemented. I'll let you two work out any kinks there.

================
Comment at: lldb/unittests/Interpreter/TestAutoRepeat.cpp:25
+    SBDebugger::Initialize();
+    m_dbg = SBDebugger::Create(false /*source_init_files*/);
+    m_interp = m_dbg.GetCommandInterpreter();
----------------
The [[ http://llvm.org/docs/CodingStandards.html#comment-formatting | recommended llvm style ]] for this is `/*arg_name=*/value`.

================
Comment at: lldb/unittests/Interpreter/TestAutoRepeat.cpp:61
+    m_interp.HandleCommand("", result);
+    assert(!result.Succeeded() &&
+           "The command should fail as a repeated command");
----------------
make a gtest assert out of this?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77444/new/

https://reviews.llvm.org/D77444