[Lldb-commits] [PATCH] D77568: Return correct entry in RangeDataVector::FindEntryThatContains

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 7 01:03:13 PDT 2020


labath added a comment.

This is definitely a bug, but I fear that fixing this via a linear search will cause a big performance regression. Fortunately, since D74759 <https://reviews.llvm.org/D74759> we now have a way to implement this more efficiently. Could you reimplement this function to use the binary search tree introduced in that patch?

If not, I can get around to it soon-ish, but I currently have a bunch of other things waiting in my queue...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77568/new/

https://reviews.llvm.org/D77568





More information about the lldb-commits mailing list