[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks
Shafik Yaghmour via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 6 16:22:12 PDT 2020
shafik added inline comments.
================
Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:103
+ // Helper iterator for the 'equal_range' method.
+ class CString_iterator {
+ public:
----------------
`CStringIterator`?
================
Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:134
+ private:
+ const UniqueCStringMap &m_map;
+ const Entry *m_entry_ptr;
----------------
It feels like this should be a pointer, `m_entry_ptr` is a pointer already and most uses in the class use the pointer value already.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77327/new/
https://reviews.llvm.org/D77327
More information about the lldb-commits
mailing list