[Lldb-commits] [lldb] b6cd964 - Fix typo in xfail decorator for lldb thread plan list tests

[Jim Ingham via lldb-commits]

Yes.  Now that I think about it a little more, I’m a bit surprised that on most platforms we do have to step in & back out again to step over this function.  That’s what we always used to do, but the work Greg & Co. did a little while back added the assumption that call’s return to the PC directly following the call, so we can step directly over.  Is that optimization only effective on aarch64?

Anyway, doesn’t matter, this was supposed to be testing the listing of internal plans, not our strategies for stepping.  Though it sound like if we want to ensure we are stepping directly over we might write a similar test to make sure we actually are doing that…

Jim


> On Apr 6, 2020, at 3:42 AM, Pavel Labath <pavel at labath.sk> wrote:
> 
> I guess these should go away after 4f644ff9e (which restrict the
> decorator to aarch64). Judging by
> <http://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20200330/063428.html>,
> Jim is going to look into a better solution for that this week.
> 
> pl
> 
> 
> On 06/04/2020 11:50, Jan Kratochvil wrote:
>> Hi,
>> 
>> I get XPASSes now on Fedora 31 x86_64:
>> 
>> http://lab.llvm.org:8014/builders/lldb-x86_64-fedora/builds/7169
>> http://lab.llvm.org:8014/builders/lldb-x86_64-fedora?numbuilds=1000
>> 
>> So maybe to remove the expected failure?
>> 
>> 
>> Jan
>> 
>> 
>> 
>> On Sun, 05 Apr 2020 17:18:54 +0200, Muhammad Omair Javaid via lldb-commits wrote:
>>> 
>>> Author: Muhammad Omair Javaid
>>> Date: 2020-04-05T20:16:46+05:00
>>> New Revision: b6cd964ac7cb9b55dfcdbe43c5502c2c0f6cbebc
>>> 
>>> URL: https://github.com/llvm/llvm-project/commit/b6cd964ac7cb9b55dfcdbe43c5502c2c0f6cbebc
>>> DIFF: https://github.com/llvm/llvm-project/commit/b6cd964ac7cb9b55dfcdbe43c5502c2c0f6cbebc.diff
>>> 
>>> LOG: Fix typo in xfail decorator for lldb thread plan list tests
>>> 
>>> Added: 
>>> 
>>> 
>>> Modified: 
>>>    lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py
>>> 
>>> Removed: 
>>> 
>>> 
>>> 
>>> ################################################################################
>>> diff  --git a/lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py b/lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py
>>> index b4ae9107aceb..5214a3f6b0fe 100644
>>> --- a/lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py
>>> +++ b/lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py
>>> @@ -17,7 +17,7 @@ class TestThreadPlanCommands(TestBase):
>>>     NO_DEBUG_INFO_TESTCASE = True
>>> 
>>>     @skipIfWindows
>>> -    @expectedFailureAll(oslist=["Linux"])
>>> +    @expectedFailureAll(oslist=["linux"])
>>>     def test_thread_plan_actions(self):
>>>         self.build()
>>>         self.main_source_file = lldb.SBFileSpec("main.c")
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>> 
>