[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Apr 6 02:40:53 PDT 2020
labath accepted this revision.
labath added inline comments.
Comment at: lldb/include/lldb/Core/SearchFilter.h:102
+ /// \note if not overriden, default implementation always \c true.
virtual bool ModulePasses(const FileSpec &spec);
> jankratochvil wrote:
> > I am not against it but FYI in a paragraph above there is already written: `The default implementation is "Everything Passes."`
> > English: IMO missing "returns".
> Thank you for the missing "returns". I'd like to keep the comment.
You can keep _a_ comment if you want, but this comment is even internally redundant. I don't see a need to mention overriding, saying "The default (base?) implementation returns true" should be clear enough.
CHANGES SINCE LAST ACTION
More information about the lldb-commits