[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

[walter erquinigo via Phabricator via lldb-commits]

wallace created this revision.
wallace added reviewers: labath, clayborg.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
wallace updated this revision to Diff 254990.
wallace edited the summary of this revision.
wallace added a comment.

improve description


@labath raised a concern on the way I was skipping this test. I think that was fair and I found a better way.
Now I'm skipping if the Intel features library is not present and if the processor-trace command doesn't exist.
It's worth mentioning that the Intel library is a collection of two features: intel-mpx and intel-pt. Intel PT is optional and has to be enabled at configuration step.

I had to add ExistsUserCommand to the CommandInterpreter API.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77452

Files:
  lldb/bindings/interface/SBCommandInterpreter.i
  lldb/include/lldb/API/SBCommandInterpreter.h
  lldb/source/API/SBCommandInterpreter.cpp
  lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77452.254990.patch
Type: text/x-patch
Size: 4559 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200404/953c2f3d/attachment-0001.bin>