[Lldb-commits] [lldb] 2d658c5 - Disable two new tests on Windows. They are failing but the logs are not helpful.

[Jim Ingham via lldb-commits]

Author: Jim Ingham
Date: 2020-04-03T17:14:56-07:00
New Revision: 2d658c56d57c4b355635b2bab38ba97a598c7393

URL: https://github.com/llvm/llvm-project/commit/2d658c56d57c4b355635b2bab38ba97a598c7393
DIFF: https://github.com/llvm/llvm-project/commit/2d658c56d57c4b355635b2bab38ba97a598c7393.diff

LOG: Disable two new tests on Windows.  They are failing but the logs are not helpful.

Also turn on the command trace unconditionally for TestThreadPlanCommands.py as the
tests for the Ubuntu bot don't seem to run with -t making it hard to see why this is
failing remotely.

Added: 
    

Modified: 
    lldb/test/API/functionalities/plugins/python_os_plugin/stepping_plugin_threads/TestOSPluginStepping.py
    lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/plugins/python_os_plugin/stepping_plugin_threads/TestOSPluginStepping.py b/lldb/test/API/functionalities/plugins/python_os_plugin/stepping_plugin_threads/TestOSPluginStepping.py
index 5bba48364731..1a625cee5d86 100644
--- a/lldb/test/API/functionalities/plugins/python_os_plugin/stepping_plugin_threads/TestOSPluginStepping.py
+++ b/lldb/test/API/functionalities/plugins/python_os_plugin/stepping_plugin_threads/TestOSPluginStepping.py
@@ -8,6 +8,7 @@
 
 import os
 import lldb
+from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 import lldbsuite.test.lldbutil as lldbutil
 
@@ -17,6 +18,7 @@ class TestOSPluginStepping(TestBase):
     mydir = TestBase.compute_mydir(__file__)
     NO_DEBUG_INFO_TESTCASE = True
 
+    @skipIfWindows
     def test_python_os_plugin(self):
         """Test that stepping works when the OS Plugin doesn't report all
            threads at every stop"""
@@ -24,6 +26,7 @@ def test_python_os_plugin(self):
         self.main_file = lldb.SBFileSpec('main.cpp')
         self.run_python_os_step_missing_thread(False)
 
+    @skipIfWindows
     def test_python_os_plugin_prune(self):
         """Test that pruning the unreported PlanStacks works"""
         self.build()

diff  --git a/lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py b/lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py
index 30fdb218fc2e..25b184ee406f 100644
--- a/lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py
+++ b/lldb/test/API/functionalities/thread_plan/TestThreadPlanCommands.py
@@ -5,6 +5,7 @@
 
 
 import lldb
+from lldbsuite.test.decorators import *
 import lldbsuite.test.lldbutil as lldbutil
 from lldbsuite.test.lldbtest import *
 
@@ -15,6 +16,7 @@ class TestThreadPlanCommands(TestBase):
 
     NO_DEBUG_INFO_TESTCASE = True
 
+    @skipIfWindows
     def test_thread_plan_actions(self):
         self.build()
         self.main_source_file = lldb.SBFileSpec("main.c")
@@ -32,9 +34,8 @@ def check_list_output(self, command, active_plans = [], completed_plans = [], di
         num_discarded = len(discarded_plans)
 
         interp.HandleCommand(command, result)
-        if self.TraceOn():
-            print("Command: %s"%(command))
-            print(result.GetOutput())
+        print("Command: %s"%(command))
+        print(result.GetOutput())
 
         if num_active == 0 and num_completed == 0 and num_discarded == 0:
             self.assertFalse(result.Succeeded(), "command: '%s' succeeded when it should have failed: '%s'"%