[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

Saleem Abdulrasool via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 3 12:57:50 PDT 2020


compnerd marked an inline comment as done.
compnerd added inline comments.


================
Comment at: lldb/test/Shell/Process/Windows/process_load.cpp:3
+
+// REQUIRES: system-windows
+// RUN: %build --compiler=clang-cl -o %t.exe -- %s
----------------
JDevlieghere wrote:
> We should probably have a `lit.local.cfg` in the Windows directory with 
> 
> ```
> if 'system-windows' not in config.available_features:
>   config.unsupported = True
> 
> ```
I think that's a good idea, but, should be a separate change - it isn't related to the load/unload functionality.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77287/new/

https://reviews.llvm.org/D77287





More information about the lldb-commits mailing list