[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl
Konrad Wilhelm Kleine via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 3 03:11:49 PDT 2020
kwk created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
These three `SearchFilter` methods all return `true` by their default
implementation:
virtual bool ModulePasses(const FileSpec &spec);
virtual bool ModulePasses(const lldb::ModuleSP &module_sp);
virtual bool AddressPasses(Address &addr);
virtual bool CompUnitPasses(FileSpec &fileSpec);
virtual bool CompUnitPasses(CompileUnit &compUnit);
That's why I've documented the default behavior and remove the overrides
in these `SearchFilter`-subclasses which all just repeated the default
implementation: `SearchFilterByModule`, `SearchFilterByModuleList`.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77376
Files:
lldb/include/lldb/Core/SearchFilter.h
lldb/source/Core/SearchFilter.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77376.254736.patch
Type: text/x-patch
Size: 3622 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200403/6b789f41/attachment-0001.bin>
More information about the lldb-commits
mailing list