[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 3 02:07:25 PDT 2020
jankratochvil added a comment.
In D77336#1959094 <https://reviews.llvm.org/D77336#1959094>, @kwk wrote:
> Could you explain, why this was done please?
As D77327 <https://reviews.llvm.org/D77327> removes `num_die_matches` as now it is a callback so one cannot use it anymore after D77327 <https://reviews.llvm.org/D77327>. Exact replacement would be to count the number of times the callback was called. But that would keep it buggy, apparently the intention was to copy the condition above:
if (types.GetSize() >= max_matches)
So that if the iteration stopped because of too many matches we do not add even more matches in this `Clang modules` block downward.
It was implemented by: SymbolFileDWARF: Unconditionally scan through clang modules. NFCish <https://github.com/llvm/llvm-project/commit/fe9eaadd68307347d97698fd0a1646827eafd290>
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits