[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

Konrad Wilhelm Kleine via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 3 01:02:33 PDT 2020

kwk accepted this revision.
kwk added a comment.
This revision is now accepted and ready to land.

No need to split this into multiples revisions. It is just a rewrite of some odd nesting.

Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2943
+        // Make sure the decl contexts match all the way up
+        if (dwarf_decl_ctx != type_dwarf_decl_ctx)
+          continue;
jankratochvil wrote:
> kwk wrote:
> > This looks like a logic change and I wonder if it should go in a separate patch, maybe?
> This should be NFC, do I miss something?
> From:
> ```
> if (a == b) {
>   c;
> }
> ```
> The patch changes it to:
> ```
> if (a != b)
>   continue;
> c;
> ```
Ah, now I see that it was previously a block on the right side of the diff :).

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list