[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

Fri Apr 3 01:02:29 PDT 2020

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Ok, I think we've done what we can here.

In D76471#1958814 <https://reviews.llvm.org/D76471#1958814>, @aprantl wrote:

> > Yeah, it seems acceptable. The "sdk type" argument still seems somewhat redundant. Theoretically we could pass in just the triple component out the xcodesdk object, but that would just mean the individual platforms would have to reconstruct the XcodeSDK object, which is already present in the caller, so it's not ideal either...
>
> It's an entire string, not just the type, because it also contains an (optional) version number.

err.. I meant "just the _version_ component", but it sounds like you are saying you need more than the version.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76471/new/

https://reviews.llvm.org/D76471