[Lldb-commits] [PATCH] D77369: Augment the symbol type classification for dyld trie exports with more detail

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda created this revision.
jasonmolenda added reviewers: labath, clayborg.
jasonmolenda added a project: LLDB.

My patch to augment the symbol table in Mach-O files with the dyld trie exports data structure only categorized symbols as code or data, but Greg Clayton had a patch to do something similar to swift a few years ago that had a more extensive categorization of symbols, as well as extracting some objc class/ivar names from the entries. This patch is basically just Greg's, updated a bit and with a test case added to it.

I'm most interested for any better ideas for a test where I get two symbols by a name search, and want to verify that one symbol has an objc type and the other symbol has a second objc type, it doesn't matter the order of the symbols returned.  The test case addition works, but it's not pretty - I was trying to think of a better way to do this but didn't come up with anything in the moment.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77369

Files:
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  lldb/test/API/macosx/dyld-trie-symbols/Makefile
  lldb/test/API/macosx/dyld-trie-symbols/TestDyldTrieSymbols.py
  lldb/test/API/macosx/dyld-trie-symbols/main.cpp
  lldb/test/API/macosx/dyld-trie-symbols/main.mm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77369.254711.patch
Type: text/x-patch
Size: 11668 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200403/947886b8/attachment.bin>