[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace

[walter erquinigo via Phabricator via lldb-commits]

wallace created this revision.
wallace added reviewers: labath, clayborg.
Herald added subscribers: lldb-commits, mgrang.
Herald added a project: LLDB.
wallace updated this revision to Diff 254576.
wallace added a comment.

fix typos

I think the quarantine is reducing my IQ overall...


In this diff of mine D77186 <https://reviews.llvm.org/D77186> I introduce a bug in the replace operation, where I was failing fast by mistake.
Besides, a similar problem existed in the insert-after operation, where it was failing fast.

Finally, the remove operation was wrong, as it was not using the indices provided by the users.

I fixed those issues and added some tests account for cases with multiple elements in these requests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77324

Files:
  lldb/source/Interpreter/OptionValuePathMappings.cpp
  lldb/test/API/functionalities/source-map/TestTargetSourceMap.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77324.254576.patch
Type: text/x-patch
Size: 8635 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200402/cb8f1106/attachment-0001.bin>