[Lldb-commits] [PATCH] D77324: [source maps] Fix remove, insert-after and replace
walter erquinigo via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 2 11:56:00 PDT 2020
wallace created this revision.
wallace added reviewers: labath, clayborg.
Herald added subscribers: lldb-commits, mgrang.
Herald added a project: LLDB.
wallace updated this revision to Diff 254576.
wallace added a comment.
I think the quarantine is reducing my IQ overall...
In this diff of mine D77186 <https://reviews.llvm.org/D77186> I introduce a bug in the replace operation, where I was failing fast by mistake.
Besides, a similar problem existed in the insert-after operation, where it was failing fast.
Finally, the remove operation was wrong, as it was not using the indices provided by the users.
I fixed those issues and added some tests account for cases with multiple elements in these requests.
rG LLVM Github Monorepo
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 8635 bytes
Desc: not available
More information about the lldb-commits