[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

Saleem Abdulrasool via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 2 09:44:23 PDT 2020

compnerd added a comment.

Thanks for the hint about the string conversion, however, I think that it's going to complicate things as the string is going to be a mixture of UTF-8 and UTF-16 content.

As to the testing, `functionalities/load_using_paths/TestLoadUsingPaths.py` is not applicable to Windows.  In fact, I don't really see a good way to really test much of this outside the context of the swift REPL which forces the loading of a DLL which is in fact how I discovered this.  If there is an easy way to ensure that the dll that is needed is in the user's `PATH`, then I suppose creating an empty dll and loading that is theoretically possible, but that too can have a lot of flakiness due to dependencies to build and all.

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list