[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

[Saleem Abdulrasool via Phabricator via lldb-commits]

compnerd created this revision.
compnerd added reviewers: JDevlieghere, xiaobai.
compnerd added a project: LLDB.

Add some very basic support for `DoLoadImage` and `UnloadImage` for Windows.  This was previously not implemented and would result in a failure at runtime that is hard to detect.

This implementation is extremely limited but serves as a starting point for proper support for loading a library.  Ideally, the user input would be converted from UTF-8 to UTF-16.  This requires additional heap allocations and conversion logic.  Error recovery there requires additional allocations both from the local heap and the global heap.

This support enables the use of LLDB's Swift REPL on Windows.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77287

Files:
  lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
  lldb/source/Plugins/Platform/Windows/PlatformWindows.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77287.254419.patch
Type: text/x-patch
Size: 5899 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200402/90238e5a/attachment.bin>