[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 1 02:43:48 PDT 2020


teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

Ok, no more complaints from my side. LGTM



================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1256
+      name,
+      parent_desc ? const_cast<clang::Module *>(parent_desc->getModuleOrNull())
+                  : nullptr,
----------------
aprantl wrote:
> here ^^
True, it seems we can't fix that. Also the ExternalASTSource uses non-const modules, so I guess that's fine then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75488/new/

https://reviews.llvm.org/D75488





More information about the lldb-commits mailing list