[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

[Raphael Isemann via Phabricator via lldb-commits]

teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.

Sorry for resetting this back from accepted :)



================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1260
+
+  module->Name = name.str();
+  return ast_source->RegisterModule(module);
----------------
Why is that done? The module should already have the correct name when it is returned from findOrCreateModule (where we pass the same name and then create the new module with that name).

If this line is removed, do we still need D75561?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75488/new/

https://reviews.llvm.org/D75488