[Lldb-commits] [lldb] 075b610 - Recommit "[lldb] Make TestExprDiagnostics.py pass again after enabling Fix-Its in test"

Davide Italiano via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 30 14:24:15 PDT 2020


Author: Davide Italiano
Date: 2020-03-30T14:24:06-07:00
New Revision: 075b610403a7d151ee9056aa490233bcd4248718

URL: https://github.com/llvm/llvm-project/commit/075b610403a7d151ee9056aa490233bcd4248718
DIFF: https://github.com/llvm/llvm-project/commit/075b610403a7d151ee9056aa490233bcd4248718.diff

LOG: Recommit "[lldb] Make TestExprDiagnostics.py pass again after enabling Fix-Its in test"

This reverts commit 55ed09d32e2602eba1dbb8aba1985246739c3909 as
it was not responsible for breaking the bots. Sorry.

Added: 
    

Modified: 
    lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
index da29d7b2c1af..b5eb552badb5 100644
--- a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
+++ b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
@@ -60,10 +60,10 @@ def test_source_and_caret_printing(self):
         self.assertIn("<user expression 3>:1:10", value.GetError().GetCString())
 
         # Multiline top-level expressions.
-        value = frame.EvaluateExpression("void x() {}\nvoid foo(unknown_type x) {}", top_level_opts)
+        value = frame.EvaluateExpression("void x() {}\nvoid foo;", top_level_opts)
         self.assertFalse(value.GetError().Success())
-        self.assertIn("\nvoid foo(unknown_type x) {}\n         ^\n", value.GetError().GetCString())
-        self.assertIn("<user expression 4>:2:10", value.GetError().GetCString())
+        self.assertIn("\nvoid foo;\n     ^", value.GetError().GetCString())
+        self.assertIn("<user expression 4>:2:6", value.GetError().GetCString())
 
         # Test that we render Clang's 'notes' correctly.
         value = frame.EvaluateExpression("struct SFoo{}; struct SFoo { int x; };", top_level_opts)


        


More information about the lldb-commits mailing list