[Lldb-commits] [lldb] 55ed09d - Revert "[lldb] Make TestExprDiagnostics.py pass again after enabling Fix-Its in test"

[Davide Italiano via lldb-commits]

Author: Davide Italiano
Date: 2020-03-30T13:58:18-07:00
New Revision: 55ed09d32e2602eba1dbb8aba1985246739c3909

URL: https://github.com/llvm/llvm-project/commit/55ed09d32e2602eba1dbb8aba1985246739c3909
DIFF: https://github.com/llvm/llvm-project/commit/55ed09d32e2602eba1dbb8aba1985246739c3909.diff

LOG: Revert "[lldb] Make TestExprDiagnostics.py pass again after enabling Fix-Its in test"

This reverts commit 502a06fcdafa637a9890da16c2734bc1a36010f6 as it
breaks the macOS bots. Raph will take a look and re-commit.

Added: 
    

Modified: 
    lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
index b5eb552badb5..da29d7b2c1af 100644
--- a/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
+++ b/lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
@@ -60,10 +60,10 @@ def test_source_and_caret_printing(self):
         self.assertIn("<user expression 3>:1:10", value.GetError().GetCString())
 
         # Multiline top-level expressions.
-        value = frame.EvaluateExpression("void x() {}\nvoid foo;", top_level_opts)
+        value = frame.EvaluateExpression("void x() {}\nvoid foo(unknown_type x) {}", top_level_opts)
         self.assertFalse(value.GetError().Success())
-        self.assertIn("\nvoid foo;\n     ^", value.GetError().GetCString())
-        self.assertIn("<user expression 4>:2:6", value.GetError().GetCString())
+        self.assertIn("\nvoid foo(unknown_type x) {}\n         ^\n", value.GetError().GetCString())
+        self.assertIn("<user expression 4>:2:10", value.GetError().GetCString())
 
         # Test that we render Clang's 'notes' correctly.
         value = frame.EvaluateExpression("struct SFoo{}; struct SFoo { int x; };", top_level_opts)