[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

[walter erquinigo via Phabricator via lldb-commits]

wallace marked 2 inline comments as done.
wallace added inline comments.


================
Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py:25-43
+        source_basename = 'main.cpp'
+        source_path = os.path.join(os.getcwd(), source_basename)
+
+        new_source_folder = os.path.join(os.path.dirname(os.getcwd()), 'moved_location')
+        new_source_path = os.path.join(new_source_folder, source_basename)
+
+        def cleanup():
----------------
labath wrote:
> Please make sure none of these commands modify the source tree. You can look at `test/API/source-manager/Makefile` for an example of how to build a binary to reference files in the build tree.
thanks, will do


================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1974
       // Add this breakpoint info to the response
       AppendBreakpoint(pair.second.bp, response_breakpoints);
     }
----------------
labath wrote:
> What about breakpoints in dynamically loaded shared libraries? Should you be remembering the original path somewhere so that one you can set it here too?
This case is different, as function breakpoints are set by the IDE without referring to any source path, as they are equivalent to making 'b function_name'. Probably function breakpoints are not working correctly, so I'll have to fix it any of these days using the expensive query I mentioned above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76968/new/

https://reviews.llvm.org/D76968