[Lldb-commits] [PATCH] D77000: [lldb] [PECOFF] Check that PECallFrameInfo operates on the expected architecture before interpreting RuntimeFunction structs
Aleksandr Urakov via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Mar 30 00:30:03 PDT 2020
aleksandr.urakov added a comment.
Hello! But does the format of an exception directory for aarch64 differ completely from x86-64 one? Can we somehow adopt the existing parser to support it? If we can, I think that this check looks good (we encapsulate the difference inside `PECallFrameInfo`). Or may be it is worth to make a different parser for aarch64? Then I think the check would look better in `ObjectFilePECOFF::CreateEHCallFrameInfo` (and then we will choose a right exception directory parser depending on an architecture). What do you think on this?
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits