[Lldb-commits] [PATCH] D76840: [lldb] Fix another crash in covariant type handling

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 26 05:55:42 PDT 2020


teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

To summarize IRC: I think the underlying cause here is that we get the Imported callback from the ASTImporter and then recursively start a completely new import process from that. I don't think that's actually supported by the ASTImporter so we probably should do the same thing we do elsewhere and queue all decls that need to be imported (see `CompleteTagDeclsScope`). But this improves the overall situation so this should land until this is properly fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76840/new/

https://reviews.llvm.org/D76840





More information about the lldb-commits mailing list