[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 24 11:16:59 PDT 2020


JDevlieghere added a comment.

In D76697#1939634 <https://reviews.llvm.org/D76697#1939634>, @davide wrote:

> Please don't do this. I've seen that assertion triggering. If anything, you might want to make a `lldbassert`.


Did you investigate why the assertion triggered? Was it because of the forward declaration or was it one of the "other weird cases". To me this change seems perfectly in line with https://lldb.llvm.org/resources/contributing.html


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76697/new/

https://reviews.llvm.org/D76697





More information about the lldb-commits mailing list