[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/include/lldb/Utility/FileCollector.h:26
+private:
+  bool addDSYM(const llvm::Twine &file);
+};
----------------
This is something I've struggled with before. If I'm inheriting from an LLVM class do I use LLVM or LLDB naming schemes?


================
Comment at: lldb/source/Utility/FileCollector.cpp:1
+//===-- FileCollector.cpp ---------------------------------------*- C++ -*-===//
+//
----------------
The C++ is redundant. This is a .cpp file, so it's not ambiguous which language this is.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76672/new/

https://reviews.llvm.org/D76672