[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

Mon Mar 23 22:49:42 PDT 2020

MaskRay added a comment.

commit fd868f517d2c5ca8c0f160dbec0857b14ecf74c1 <https://reviews.llvm.org/rGfd868f517d2c5ca8c0f160dbec0857b14ecf74c1> should be associated with `Differential Revision: https://reviews.llvm.org/D76111`.

The revert of fd868f517d2c5ca8c0f160dbec0857b14ecf74c1 <https://reviews.llvm.org/rGfd868f517d2c5ca8c0f160dbec0857b14ecf74c1> should explain why fd868f517d2c5ca8c0f160dbec0857b14ecf74c1 <https://reviews.llvm.org/rGfd868f517d2c5ca8c0f160dbec0857b14ecf74c1> was reverted.

Please don't make a commit whose description contains just one word `fix`.

If you are unsure, upload a new diff to trigger Harbormaster, check its test status on 3 Linux/Windows/macOS, instead of committing and reverting like playing a game. Every commit has a permanent record which will be shared among thousands of developers and can increase the size of the repository. Please be careful.

`Subscribers:` and `Tags:` lines are generally considered useless. You can strip them with:

  arcfilter () {
          git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend -F -
  }

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76111/new/

https://reviews.llvm.org/D76111