[Lldb-commits] [lldb] ae37e22 - [lldb/Reproducers] Mark reproducer test directory as unsupported on Windows
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Mon Mar 23 09:54:31 PDT 2020
Author: Jonas Devlieghere
Date: 2020-03-23T09:54:11-07:00
New Revision: ae37e2285d233f28217e4e95a3ff71059c7ee8c7
URL: https://github.com/llvm/llvm-project/commit/ae37e2285d233f28217e4e95a3ff71059c7ee8c7
DIFF: https://github.com/llvm/llvm-project/commit/ae37e2285d233f28217e4e95a3ff71059c7ee8c7.diff
LOG: [lldb/Reproducers] Mark reproducer test directory as unsupported on Windows
Reproducers are unsupported on Windows. Rather than having a UNSUPPORTED
line in every test, just skip the whole subdirectory.
Added:
Modified:
lldb/test/Shell/Reproducer/Functionalities/TestDataFormatter.test
lldb/test/Shell/Reproducer/Functionalities/TestExpressionEvaluation.test
lldb/test/Shell/Reproducer/Functionalities/TestImageList.test
lldb/test/Shell/Reproducer/Functionalities/TestStepping.test
lldb/test/Shell/Reproducer/TestCaptureEnvOverride.test
lldb/test/Shell/Reproducer/TestCrash.test
lldb/test/Shell/Reproducer/TestDiscard.test
lldb/test/Shell/Reproducer/TestDump.test
lldb/test/Shell/Reproducer/TestGDBRemoteRepro.test
lldb/test/Shell/Reproducer/TestMultipleTargets.test
lldb/test/Shell/Reproducer/TestRelativePath.test
lldb/test/Shell/Reproducer/TestReuseDirectory.test
lldb/test/Shell/Reproducer/TestSynchronous.test
lldb/test/Shell/Reproducer/TestWorkingDir.test
lldb/test/Shell/Reproducer/lit.local.cfg
Removed:
################################################################################
diff --git a/lldb/test/Shell/Reproducer/Functionalities/TestDataFormatter.test b/lldb/test/Shell/Reproducer/Functionalities/TestDataFormatter.test
index 7db8bc4b36cf..d133c8d3b9f9 100644
--- a/lldb/test/Shell/Reproducer/Functionalities/TestDataFormatter.test
+++ b/lldb/test/Shell/Reproducer/Functionalities/TestDataFormatter.test
@@ -1,4 +1,4 @@
-# UNSUPPORTED: system-windows, system-freebsd
+# UNSUPPORTED: system-freebsd
# This tests that data formatters continue to work when replaying a reproducer.
diff --git a/lldb/test/Shell/Reproducer/Functionalities/TestExpressionEvaluation.test b/lldb/test/Shell/Reproducer/Functionalities/TestExpressionEvaluation.test
index e2bcb2d96570..f400cef07a24 100644
--- a/lldb/test/Shell/Reproducer/Functionalities/TestExpressionEvaluation.test
+++ b/lldb/test/Shell/Reproducer/Functionalities/TestExpressionEvaluation.test
@@ -1,4 +1,4 @@
-# UNSUPPORTED: system-windows, system-freebsd
+# UNSUPPORTED: system-freebsd
# XFAIL: system-netbsd
# Flaky
diff --git a/lldb/test/Shell/Reproducer/Functionalities/TestImageList.test b/lldb/test/Shell/Reproducer/Functionalities/TestImageList.test
index db319093f174..ec8b36ea9576 100644
--- a/lldb/test/Shell/Reproducer/Functionalities/TestImageList.test
+++ b/lldb/test/Shell/Reproducer/Functionalities/TestImageList.test
@@ -1,4 +1,4 @@
-# UNSUPPORTED: system-windows, system-freebsd
+# UNSUPPORTED: system-freebsd
# This tests that image list works when replaying. We arbitrarily assume
# there's at least two entries and compare that they're identical.
diff --git a/lldb/test/Shell/Reproducer/Functionalities/TestStepping.test b/lldb/test/Shell/Reproducer/Functionalities/TestStepping.test
index 1dec9a077c7b..ba9164f4b43a 100644
--- a/lldb/test/Shell/Reproducer/Functionalities/TestStepping.test
+++ b/lldb/test/Shell/Reproducer/Functionalities/TestStepping.test
@@ -1,4 +1,4 @@
-# UNSUPPORTED: system-windows, system-freebsd
+# UNSUPPORTED: system-freebsd
# This tests that stepping continues to work when replaying a reproducer.
diff --git a/lldb/test/Shell/Reproducer/TestCaptureEnvOverride.test b/lldb/test/Shell/Reproducer/TestCaptureEnvOverride.test
index a8e7bdec250e..ef06bce8983f 100644
--- a/lldb/test/Shell/Reproducer/TestCaptureEnvOverride.test
+++ b/lldb/test/Shell/Reproducer/TestCaptureEnvOverride.test
@@ -1,4 +1,3 @@
-# UNSUPPORTED: system-windows
# This tests the LLDB_CAPTURE_REPRODUCER override.
# RUN: %lldb -b -o 'reproducer status' --capture --capture-path %t.repro /bin/ls | FileCheck %s --check-prefix CAPTURE
diff --git a/lldb/test/Shell/Reproducer/TestCrash.test b/lldb/test/Shell/Reproducer/TestCrash.test
index cb0c09aad141..1389a9b76ad3 100644
--- a/lldb/test/Shell/Reproducer/TestCrash.test
+++ b/lldb/test/Shell/Reproducer/TestCrash.test
@@ -1,4 +1,3 @@
-# UNSUPPORTED: system-windows
# This tests that a reproducer is generated when LLDB crashes.
# Start clean.
diff --git a/lldb/test/Shell/Reproducer/TestDiscard.test b/lldb/test/Shell/Reproducer/TestDiscard.test
index db9614aabb84..829aabbe2b03 100644
--- a/lldb/test/Shell/Reproducer/TestDiscard.test
+++ b/lldb/test/Shell/Reproducer/TestDiscard.test
@@ -1,4 +1,3 @@
-# UNSUPPORTED: system-windows
# This ensures that the reproducer properly cleans up after itself.
# Build the inferior.
diff --git a/lldb/test/Shell/Reproducer/TestDump.test b/lldb/test/Shell/Reproducer/TestDump.test
index c193b806b547..8300a97004bb 100644
--- a/lldb/test/Shell/Reproducer/TestDump.test
+++ b/lldb/test/Shell/Reproducer/TestDump.test
@@ -1,4 +1,3 @@
-# UNSUPPORTED: system-windows
# This tests the reproducer dump functionality.
# Generate a reproducer.
diff --git a/lldb/test/Shell/Reproducer/TestGDBRemoteRepro.test b/lldb/test/Shell/Reproducer/TestGDBRemoteRepro.test
index 609c83929292..683a7e2f5529 100644
--- a/lldb/test/Shell/Reproducer/TestGDBRemoteRepro.test
+++ b/lldb/test/Shell/Reproducer/TestGDBRemoteRepro.test
@@ -1,4 +1,4 @@
-# UNSUPPORTED: system-windows, system-freebsd
+# UNSUPPORTED: system-freebsd
# This tests the replaying of GDB remote packets.
#
diff --git a/lldb/test/Shell/Reproducer/TestMultipleTargets.test b/lldb/test/Shell/Reproducer/TestMultipleTargets.test
index ce1a5ecdd4c8..7859480e2d04 100644
--- a/lldb/test/Shell/Reproducer/TestMultipleTargets.test
+++ b/lldb/test/Shell/Reproducer/TestMultipleTargets.test
@@ -1,4 +1,4 @@
-# UNSUPPORTED: system-windows, system-freebsd
+# UNSUPPORTED: system-freebsd
# This tests the replaying with multiple targets.
diff --git a/lldb/test/Shell/Reproducer/TestRelativePath.test b/lldb/test/Shell/Reproducer/TestRelativePath.test
index 2ee4bf0c9649..fa7518784550 100644
--- a/lldb/test/Shell/Reproducer/TestRelativePath.test
+++ b/lldb/test/Shell/Reproducer/TestRelativePath.test
@@ -1,4 +1,3 @@
-# UNSUPPORTED: system-windows
# This tests relative capture paths.
# RUN: mkdir -p %t
diff --git a/lldb/test/Shell/Reproducer/TestReuseDirectory.test b/lldb/test/Shell/Reproducer/TestReuseDirectory.test
index 31b71a0f2601..a3fecced2504 100644
--- a/lldb/test/Shell/Reproducer/TestReuseDirectory.test
+++ b/lldb/test/Shell/Reproducer/TestReuseDirectory.test
@@ -1,4 +1,4 @@
-# UNSUPPORTED: system-windows, system-freebsd
+# UNSUPPORTED: system-freebsd
# Test that we can capture twice to the same directory without breaking the
# reproducer functionality.
diff --git a/lldb/test/Shell/Reproducer/TestSynchronous.test b/lldb/test/Shell/Reproducer/TestSynchronous.test
index c62cbe81aff3..f32ce8c57224 100644
--- a/lldb/test/Shell/Reproducer/TestSynchronous.test
+++ b/lldb/test/Shell/Reproducer/TestSynchronous.test
@@ -1,5 +1,4 @@
# REQUIRES: python
-# UNSUPPORTED: system-windows
# Ensure that replay happens in synchronous mode.
# RUN: rm -rf %t.repro
diff --git a/lldb/test/Shell/Reproducer/TestWorkingDir.test b/lldb/test/Shell/Reproducer/TestWorkingDir.test
index 707916bae560..1d4c7694211a 100644
--- a/lldb/test/Shell/Reproducer/TestWorkingDir.test
+++ b/lldb/test/Shell/Reproducer/TestWorkingDir.test
@@ -1,5 +1,3 @@
-# XFAIL: system-windows
-
# This tests that the reproducer can deal with relative files. We create a
# binary in a subdirectory and pass its relative path to LLDB. The subdirectory
# is removed before replay so that it only exists in the reproducer's VFS.
diff --git a/lldb/test/Shell/Reproducer/lit.local.cfg b/lldb/test/Shell/Reproducer/lit.local.cfg
index 7f4022768c87..30f97f28279d 100644
--- a/lldb/test/Shell/Reproducer/lit.local.cfg
+++ b/lldb/test/Shell/Reproducer/lit.local.cfg
@@ -6,5 +6,8 @@ if 'LLVM_DISABLE_CRASH_REPORT' in config.environment:
if 'LLDB_CAPTURE_REPRODUCER' in config.environment:
del config.environment['LLDB_CAPTURE_REPRODUCER']
+if 'system-windows' in config.available_features:
+ config.unsupported = True
+
if 'lldb-repro' in config.available_features:
config.unsupported = True
More information about the lldb-commits
mailing list