[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

Fri Mar 20 11:23:25 PDT 2020

djtodoro added a comment.

In D73534#1934105 <https://reviews.llvm.org/D73534#1934105>, @vsk wrote:

> In D73534#1933988 <https://reviews.llvm.org/D73534#1933988>, @djtodoro wrote:
>
> > In D73534#1933985 <https://reviews.llvm.org/D73534#1933985>, @djtodoro wrote:
> >
> > > Oh sorry, I thought it all has been fixed, since all the tests pass.
> > >
> > > We should revert the D75036 <https://reviews.llvm.org/D75036> until we fix all the issues.
> >
> >
> > @dstenb do you agree?
>
>
> This was an oversight on my part, the fix from D76164 <https://reviews.llvm.org/D76164> was not complete. I need a few more minutes to write a test, but I should be able to fix this very soon. If we can fix-forward, that would be easier.

@vsk That would be great. Thanks a lot!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73534/new/

https://reviews.llvm.org/D73534