[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1318
+
+static llvm::VersionTuple ParseSDKVersion(llvm::StringRef &name) {
+  unsigned i = 0;
----------------
We should document what we expect the format to be. I mean I can deduce it from the code but I would prefer to have it spelled out and then check the code parses the expected format correctly.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1336
+
+std::tuple<int, llvm::VersionTuple> SDK::Parse() const {
+  llvm::StringRef input = m_name.GetStringRef();
----------------
We should have tests for this and the rest of the methods here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76471/new/

https://reviews.llvm.org/D76471