[Lldb-commits] [PATCH] D76476: Add formatter for libc++ std::unique_ptr

[Vedant Kumar via Phabricator via lldb-commits]

vsk added a comment.

Awesome :)



================
Comment at: lldb/include/lldb/DataFormatters/FormattersHelpers.h:59
 
+lldb::ValueObjectSP GetValueOfCompressedPair(ValueObject &pair);
+
----------------
Mind adding ‘libcxx’ somewhere in the function name, to avoid confusion?


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:618
+      "unique_ptr synthetic children",
+      ConstString("^(std::__[[:alnum:]]+::)unique_ptr<.+>(( )?&)?$"),
+      stl_synth_flags, true);
----------------
Does this need to match for rvalue refs, like ‘unique_ptr<blah> &&’?


================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:728
+                "libc++ std::unique_ptr summary provider",
+                ConstString("^std::__[[:alnum:]]+::unique_ptr<.+>(( )?&)?$"),
+                stl_summary_flags, true);
----------------
Can we share the regex definition?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76476/new/

https://reviews.llvm.org/D76476