[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/include/lldb/Symbol/Type.h:201-202
+  uint32_t GetPayload() { return m_payload; }
+  /// Return the language-specific payload.
+  void SetPayload(uint32_t opaque_payload) { m_payload = opaque_payload; }
 
----------------
It doesn't look like this setter is needed, as the single usage has now been changed to a constructor argument. And if this is immutable, then in turn some methods of `TypePayloadClang` become unneeded (SetIsCompleteObjCClass)


================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:64
+  explicit TypePayloadClang(uint32_t opaque_payload) : m_payload(opaque_payload) {}
+  operator uint32_t() { return m_payload; }
+
----------------
maybe make this explicit too (and augment it with a `encode` method to make the usage less weird)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75562/new/

https://reviews.llvm.org/D75562